report chart updates

Bug fixes and layout/style updates for the report chart/graphs. Addresses #51
PromInc · May 18, 2017 · 070bf81 · 070bf81
1 parent 078f15e
commit 070bf81
Show file tree

Hide file tree

Showing 6 changed files with 182 additions and 82 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,10 @@
+## 2.5.3 - 2017-05-17
+### Bug Fixes
+- Report chart usability and rendering improvements
+
+### Addresses Github Issues
+- #51
+
 ## 2.5.2 - 2017-04-20
 ### Added
 - CRON functionality

diff --git a/organic-search-analytics/css/styles.css b/organic-search-analytics/css/styles.css
@@ -212,7 +212,18 @@ table.sidebysidetable td {
 	font-weight: bold;
 }
 
-#reportChartContainer { padding-bottom: 70px; }
+#reportChartContainer {
+	padding-bottom: 3%;
+}
+
+#reportchart.bar {
+    max-width: 90%;
+}
+
+#chartDataCallout {
+	height: 40px;
+	margin-left: 2%;
+}
 
 .processing {
 	font-weight: bold;
@@ -238,6 +249,8 @@ table.sidebysidetable td {
 
 .clear { clear:both; }
 
+.italic { font-style: italic; }
+
 footer { margin-top: 50px; padding: 20px 20px 15px; background-color:#DDDDDD; }
 
 /* Alert Box */

diff --git a/organic-search-analytics/inc/code/reports.php b/organic-search-analytics/inc/code/reports.php
@@ -24,6 +24,9 @@ class Reports
 	{
 
 
+		const EMPTY_RESULT_PLACEHOLDER = "not set";
+
+
 		public $core;
 
 

diff --git a/organic-search-analytics/inc/html/reportSettings.php b/organic-search-analytics/inc/html/reportSettings.php
@@ -131,7 +131,7 @@
 		<?php $tooltip = date( "D M jS, Y", strtotime( $row["max"] . ' -29 days' ) ) . ' to ' . date( "D M jS, Y", strtotime( $row["max"] ) ) ?>
 		<span>
 			<input type="radio" name="date_type" id="date_type_recent_30" value="recent_30"<?php echo ( isset( $reportParams['date_type'] ) && $reportParams['date_type'] == 'recent_30' ? $checkedTrue : $checkedFalse ) ?>>
-			<label for="date_type_recent_30=" tooltip="<?php echo $tooltip ?>">Past 30 Days</label>
+			<label for="date_type_recent_30" tooltip="<?php echo $tooltip ?>">Past 30 Days</label>
 		</span>
 		<?php $tooltip = date( "D M jS, Y", strtotime( $row["max"] . ' -89 days' ) ) . ' to ' . date( "D M jS, Y", strtotime( $row["max"] ) ) ?>
 		<span>
Original file line number	Diff line number	Diff line change
Expand Up		@@ -24,6 +24,9 @@ class Reports
		{


		const EMPTY_RESULT_PLACEHOLDER = "not set";


		public $core;


Expand Down