2.5.1 - custom Date Range issue #51
Comments
|
I'm unable to recreate this issue on my end. Have you made any customizations to your code? One thing I'm confused by is in http://prnt.sc/f6ygoo. You have Specific Dates selected, but I don't see the date selectors expanded. When that radio button is selected there should be two calendar displays for picking the to and from dates. This makes me think that the file /organic-search-analytics/js/lib/jquery/jquery-ui.1.11.4.custom.min.js isn't loading? Those are my initial reactions. |
|
I have the same issue, and didn't change anything. It was like this "from box" , tried Firefox and Chrome but still doesnt work. I thought you know about it and fix it later. |
Bug fixes and layout/style updates for the report chart/graphs. Addresses #51
|
This is not a known issue. I did a clean install of version 2.5.1 from Github and can not recreate this issue. Well sort of... I was able to to see a similar issue but it didn't 100% match up with the screenshots. I've done a bit of work on updating how the charts function - I feel that I have the bugs worked out of it now in version 2.5.3 Please download this version from the current master branch (not created into a release) and see if this resolves your issues. Please report back here with your findings so I know if there is more work that needs to be done. If there are issues, it would be helpful to know more about what scenarios create it:
Let me know if version 2.5.3 works for you. |
|
I can not change this either, only via URL directly |
|
I have now upgraded to the 2.5.3 version and the bug is still there. |
|
@nekromoff There must be a javascript error being thrown - possibly due to a library file not loading? jQuery, jQuery UI libraries, etc. Please press F12 to open the developer console, click the Console tab, reload the page, click the Specific Dates radio button, and then provide a screenshot showing what is in the console tab of the developer window. That will help me to understand what is failing and/or not loading. |
|
SyntaxError: unterminated string literal[Learn More] report.php:467:25 |
|
seems to be a problem in this function: |
|
The first thing that stands out to me is that you are not using the latest version - that shows that you are currently on version 2.4.3 - the current is 2.5.3 (as you stated you are using). I'd suggest ensuring your entire repository is up to date. |
|
Also a bug fix to this script was added in version 2.5.0. The version number you see in the script you pasted comes from a text file. The text file had a line break (as you can see in your pasted code), and then the javascript had issues with comprehending that text. Version 2.5.0 removed the line break as well as added a Can you please update your codebase and report back if that clears up the issue? |
|
When you select custom range, it don't display the calendars. You can see on this printscreen : http://prntscr.com/fb1cha |
|
Thank you for the screenshot - helps to see what is happening.
The function it claims is missing was added in version 2.3.7
9fcb4fb
in the file:
organic-search-analytics/is/report.js
Either this file is out of date or your browser is caching an older copy of the file.
I would start by opening the file directly in your browser. For your machine it looks like the URL would be:
http://localhost/gsc2/organic-search-analytics/is/report.js
If you see `function updateDateRange()` in this file that tells me the browser cached an older version and accessing it directly like this updated the cache in Chrome. Going back to the report and refreshing the page should now work.
If you don't see the function then your code is out of date. I don't see in your screenshot what version you have installed.
Please let me know what you find. If the browser is caching these files I may have to add a cache buster when loading JS and CSS assets to ensure updated files are rendered correctly.
On May 23, 2017, at 2:20 AM, ctseo <[email protected]<mailto:[email protected]>> wrote:
When you select custom range, it don't display the calendars. You can see on this printscreen : http://prntscr.com/fb1cha
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub<#51 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AG-v0TBrJyypyDhCsCdXNXs1RveWrUTjks5r8oivgaJpZM4NZI9B>.
|
|
Hello. report.js file: http://prntscr.com/fb1ztk I have the latest version... 2.5.3. I replaced all files from 2,.5.3 zip from my gsc2 folder. |
|
The latest screenshot doesn't show if the function is there or not. But the last lines imply that the function is there. Now that you've loaded that file directly have you tried re-running a report? Do the date selectors show?
The other thing to check is on the report page look at the Sources tab of the developer console (F12) and expand the directory structure on the left to confirm this JS file is loading and has the updateDateRange() function in it.
On May 23, 2017, at 3:26 AM, ctseo <[email protected]<mailto:[email protected]>> wrote:
Hello.
It's not a cache problem. I used incognito too... and same problem.
report.js file: http://prntscr.com/fb1ztk
I have the latest version... 2.5.3. I replaced all files from 2,.5.3 zip from my gsc2 folder.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub<#51 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AG-v0bwwiMr-okjss-lV9BdBodBoSGzgks5r8phJgaJpZM4NZI9B>.
|
|
I have done git pull, but still see the same bug and same version that you said is from the previous file. |
|
OK, you might have changed the directory structure between the versions, so now the organic-search-analytics folder is duplicated in the former organic-search-analytics folder with the new version. Once this has been fixed, the new version works. |
|
Yes PromInc, you are right! I don't have this function updateDateRange() : http://prntscr.com/fb39gq I tried only update or daterange ... nothing. |
|
@nekromoff - it sounds like you may have found the root issue? If I'm following you correctly, in the root directory you are finding files - When doing updates to your repository it could be done via a git pull (either command line or the desktop utility) or by manually downloading the zip file and updating your local copy of the code. Using a git pull it will delete and move files as needed, where as using the zip download you are in charge of maintaining the file system. It's probably best to delete all files and replace them if you are using the .zip file method WITH EXCEPTION of the @nekromoff - Can you please confirm that this issue is no longer an issue for you? @ctseo and @nepohex - Please look through your codebase on your local machines and ensure that the files and file structure match that of the repository as it appears you may have the same issue as @nekromoff identified - accessing the project through an old set of code that is not longer supported. |
|
I have the whole project in /gsc that seems to be correct. Anyway, there are the other two bugs #56 and #57 that I have encountered after downloading as ZIP. I am not sure why the former (abandoned) files where not removed by git pull. |
|
@nekromoff did you run the upgrade scripts? You should have to run 2 upgrade scripts since you came from 2.4.3 to 2.5.3. In your web browser, click the Home button, then the text link Upgrade Scripts. Make sure you run the scripts in order as well - clicking the following buttons:
Follow any other instructions there as well, but this will update your database. |
|
Nope. It didn't work for me. All files from zip seems to be ok. I tried to delete all except config & log directory and replace with the new version and i have same problem. Can be this problem because i have a lot of data in mysql, and calendar it freeze when try to get data ? |
|
I did, it took some time as I have over 188k rows.
…On Tue, May 23, 2017 at 3:13 PM, PromInc ***@***.***> wrote:
@nekromoff <https://github.com/nekromoff> did you run the upgrade
scripts? You should have to run 2 upgrade scripts since you came from 2.4.3
to 2.5.3. In your web browser, click the *Home* button, then the text
link *Upgrade Scripts*.
Make sure you run the scripts in order as well - clicking the following
buttons:
- Run Update for Version 2.x.x to 2.5.0
- Run Update for Version 2.5.0 to 2.5.1
Follow any other instructions there as well, but this will update your
database.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#51 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AIJ3zdbfM-7oWZx0_Af9l0pguZep0_aFks5r8tt1gaJpZM4NZI9B>
.
|
|
@ctseo No the amount of data isn't the issue. According to your screenshots it is a javascript error.
|
|
@nekromoff when you downloaded as a zip file, did you set all of the configuration settings (database, etc.) or copy a copy of the |
|
I have a older version, 2.3.1 where seems to work. I will try to update to 2.4 to see there is the problem. |
|
Sure, I have not touched config folder at all. Only used re-"Save" button
as it required me to do.
…On Tue, May 23, 2017 at 3:20 PM, PromInc ***@***.***> wrote:
@nekromoff <https://github.com/nekromoff> when you downloaded as a zip
file, did you set all of the configuration settings (database, etc.) or
copy a copy of the config/config.php file into the newly setup project?
Without setting those settings or using an existing copy of a config.php
file the project doesn't know how to connect to the database, which is
where the report settings are saved.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#51 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AIJ3zZ1Rb-sIevCZH0B-GghqbFU2FSifks5r8t0QgaJpZM4NZI9B>
.
|
|
@PromInc from branch: report-chart-updates it's not working. :) I had 2.4x version and works well.. when going to upgrade.. it's broken. |
|
@PromInc : maybe it help you, you can see the printscreen: http://prntscr.com/fb5jvy |
|
@ctseo Can you right click on the page and choose View Page Source. Scroll to the very bottom of the page and provide a screenshot of that? I'm wondering if you are getting a PHP error and the page isn't completely rendering. The javascript file that's missing is loaded at the bottom of the page. Can you please provide me information on your webserver setup as asked prior? |
|
@PromInc : I don't see any php errors. I use xamp v3.2.1 Screenshot: http://prntscr.com/fb5s8p |
|
@ctseo Does the end of the source code look something like this? The two most notable lines here are these: These tell me that the end of the page is loading as desired and the request to load the This is the other reason I asked for a screenshot - a picture says 1,000 lines of code. :) |
|
mine looks like this:
<div id="versionBlock" class="floatright"> <span>ver
2.5.3</span> <span id="upgradeVersion" class="floatright"
style="display:none;">A newer version is available. <a>Download <span
id="upgradeVersionNumber"></span> now!</a></span> <script
type="text/javascript"> $.get('https://api.github.com/repos/prominc/organic-search-analytics/releases/latest',
function (data) { var latestVersion = data.tag_name; if(
latestVersion > '2.5.3' ) { $('#upgradeVersion a').attr('href',
data.zipball_url); $('#upgradeVersion a
span#upgradeVersionNumber').text(latestVersion); $('#upgradeVersion').show(); } }); </script>
and only:
<script type="text/javascript" src="js/script.js"></script>
is included in the header.
However after clicking custom date range, it does not offer any dates to enter.
…On Tue, May 23, 2017 at 3:58 PM, PromInc ***@***.***> wrote:
@ctseo <https://github.com/ctseo> Does the end of the source code look
something like this?
<script type="text/javascript" src="js/report.js"></script>
<footer>
<div class="floatleft">
Developed by <a href="http://www.promincproductions.com/blog" target="_blank">Brian Prom</a>
</div>
<div id="versionBlock" class="floatright">
<span>ver 2.5.1</span>
<span id="upgradeVersion" class="floatright" style="display:none;">A newer version is available. <a>Download <span id="upgradeVersionNumber"></span> now!</a></span>
<script type="text/javascript">
$.get('https://api.github.com/repos/prominc/organic-search-analytics/releases/latest', function (data) {
var latestVersion = data.tag_name;
if( latestVersion > '2.5.1' ) {
$('#upgradeVersion a').attr('href', data.zipball_url);
$('#upgradeVersion a span#upgradeVersionNumber').text(latestVersion);
$('#upgradeVersion').show();
}
});
</script>
</div>
<div class="clear"></div>
</footer>
</body>
</html>
The two most notable lines here are these:
<script type="text/javascript" src="js/report.js"></script>
and
</html>
These tell me that the end of the page is loading as desired and the
request to load the js/report.js file is being made. Your prior
screenshots show that this request isn't being made - not sure why that
would be.
This is the other reason I asked for a screenshot - a picture says 1,000
lines of code. :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#51 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AIJ3zR3PjYE0qQJZhiQZ_BXBlSvGLufFks5r8uXzgaJpZM4NZI9B>
.
|
|
@nekromoff you're stumping me...
|
|
This is the head:
```
<html> <head> <title>Reporting | Organic Search
Analytics</title> <link rel="stylesheet"
href="css/styles.css"> <link rel="stylesheet"
href="css/lib/jquery/jquery-ui.1.11.4.custom.min.css"> <link
rel="stylesheet"
href="css/lib/font-awesome/font-awesome.min.css"> <script
language="javascript" type="text/javascript"
src="js/lib/jquery/jquery-1.11.3.min.js"></script> <script
src="js/lib/jquery/jquery-ui.1.11.4.custom.min.js"></script> <script
type="text/javascript" src="js/script.js"></script> </head>
```
I have just pasted the code without closing ```</html>```, otherwise it's there.
|
|
I see the same code here in the master branch: |
|
Thank you @nekromoff - my apologies I miss-read one of your prior posts. script.js is in the head (that's good). So you don't see Ok, who here feels brave and wants to modify a file to test a possible solution? :) https://github.com/PromInc/organic-search-analytics/blob/master/organic-search-analytics/inc/html/_foot.php#L3 https://github.com/PromInc/organic-search-analytics/blob/master/organic-search-analytics/inc/html/_foot.php#L4 |
|
OK, it's pretty clear now why the report.js is not included: You are incorrectly using $GLOBALS['scriptName']: checking output of: instead you should change it to: Once this is changed, your script works fine! |
|
I think the bigger issue is that I shouldn't be using |
|
I agree with that, too 👍 |
|
@PromInc : Ok .. so the solution is: |
Revert code that was proposed in #31, ported to #38, and mistakenly deployed via 9d72b4d that attempts to work with an Apache alias environment. The proposed code modified the $GLOBALS['basedirWebServer'] and $GLOBALS['appInstallDir'] variables, which resulted in unexpected values in $GLOBALS['scriptName']. The final result of this code change is that under certain Apache configurations it was not possible to reliably use $GLOBALS['scriptName'] to detect what page was being rendered and thus conditional situations were failing. The example brought up in #51 is that a javascript file was not being loaded on the reports.php page.
|
I agree that I'd prefer to use an alternate solution however and have created a branch for testing this solution. @nekromoff and @ctseo I'd appreciate it if you were able to test this solution before I merge it into the master branch. Please test branch Issue#51-report.js-not-loading. Looking deeper at this issue, I see the root of the problem was a change that was not intended to be deployed yet was made in version 2.5.0. A request to modify some code to handle an Apache alias environment was made in #31 (and is now tracked under #38). This unintentionally was added in 9d72b4d which is causing the root of the issue. Admittedly I don't fully understand the Apache alias environment, it's need, and thus can't put my stamp of guarantee on the fact that this code was a safe choice to add (and it's proven to not be safe as written). My reason for this as the solution vs what @nekromoff offered is that this is the true root of the issue and I see that It is my belief that this solution should also resolve #56 and #57. |
|
@PromInc : it's working :) |
|
Thank you @ctseo I have merged this fix into the master branch (as well as another bug fix for the reports if a query or page has a single quote in it). I appreciate you all bringing up this issue and helping me to debug it. It only affects Apache servers which is not my primary hosting/testing environment. |
Hello,
On your latest version 2.5,1, i can't chose date range and on reporting page... to change Report Settings arrow doen't work, to change something on settings.
Error 1: http://prntscr.com/f6ygoo
Error 2: http://prntscr.com/f6ygaw
http://prntscr.com/f6yhlu
The text was updated successfully, but these errors were encountered: