Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch invalid JSON from Redis and throw an error #174

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

SevaWeb011
Copy link

@SevaWeb011 SevaWeb011 commented Jan 27, 2025

I want to resolve this issue
If you have any suggestions for improving this PR, feel free to let me know

Copy link
Member

@LKaemmerling LKaemmerling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Good catch and idea!

src/Prometheus/Exception/MetricJsonException.php Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

json_decode($data, true) does not guarantee a specific return type
2 participants