Fix/audit results #68
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| /// @dev Instance of the ProofOfHumanity contract | ||
| IProofOfHumanity public proofOfHumanity; | ||
|
|
||
| string public name = "Human Vote"; |
Check warning
Code scanning / Slither
State variables that could be declared constant Warning
| IProofOfHumanity public proofOfHumanity; | ||
|
|
||
| string public name = "Human Vote"; | ||
| string public symbol = "VOTE"; |
Check warning
Code scanning / Slither
State variables that could be declared constant Warning
|
|
||
| string public name = "Human Vote"; | ||
| string public symbol = "VOTE"; | ||
| uint8 public decimals = 0; |
Check warning
Code scanning / Slither
State variables that could be declared constant Warning
| /** @dev Changes the address of the the related ProofOfHumanity contract. | ||
| * @param _proofOfHumanity The address of the new contract. | ||
| */ | ||
| function changePoH(IProofOfHumanity _proofOfHumanity) external onlyGovernor { |
Check warning
Code scanning / Slither
Conformance to Solidity naming conventions Warning
| function changeGovernor(address _governor) external onlyGovernor { | ||
| //require(msg.sender == governor, "The caller must be the governor."); | ||
| governor = _governor; | ||
| } |
Check notice
Code scanning / Slither
Missing events access control Low
| /** @dev Changes the address of the the governor. | ||
| * @param _governor The address of the new governor. | ||
| */ | ||
| function changeGovernor(address _governor) external onlyGovernor { |
Check notice
Code scanning / Slither
Missing zero address validation Low
| /** @dev Changes the address of the the governor. | ||
| * @param _governor The address of the new governor. | ||
| */ | ||
| function changeGovernor(address _governor) external onlyGovernor { |
Check warning
Code scanning / Slither
Conformance to Solidity naming conventions Warning
| * @param _account The account address. | ||
| * @return Whether the account is registered or not. | ||
| */ | ||
| function isHuman(address _account) public view returns (bool) { |
Check warning
Code scanning / Slither
Conformance to Solidity naming conventions Warning
| * @param _account The account address. | ||
| * @return The balance of the account. | ||
| */ | ||
| function balanceOf(address _account) external view returns (uint256) { |
Check warning
Code scanning / Slither
Conformance to Solidity naming conventions Warning
|
Note that the issue fixed in 753ffd5 was found internally during testing |
No description provided.