Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Codegen for futures. #3064

Merged
merged 2 commits into from
Oct 26, 2023
Merged

[Fix] Codegen for futures. #3064

merged 2 commits into from
Oct 26, 2023

Conversation

d0cd
Copy link
Collaborator

@d0cd d0cd commented Oct 25, 2023

Closes #3065

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #3064 (9d11d05) into testnet3 (04c198a) will increase coverage by 0.00%.
The diff coverage is 69.56%.

@@            Coverage Diff            @@
##           testnet3    #3064   +/-   ##
=========================================
  Coverage     78.89%   78.89%           
=========================================
  Files           164      164           
  Lines          5514     5520    +6     
  Branches       5514     5520    +6     
=========================================
+ Hits           4350     4355    +5     
- Misses         1164     1165    +1     
Files Coverage Δ
...er/passes/src/code_generation/visit_expressions.rs 72.37% <50.00%> (ø)
compiler/passes/src/flattening/flattener.rs 80.21% <80.00%> (+1.15%) ⬆️
tests/test-framework/src/error.rs 25.00% <0.00%> (ø)
...mpiler/passes/src/code_generation/visit_program.rs 76.92% <73.33%> (+0.45%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@acoglio acoglio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I'm not super-familiar with this part of the code.

@d0cd d0cd merged commit d1fbd5b into testnet3 Oct 26, 2023
7 of 8 checks passed
@d0cd d0cd deleted the fix/codegen-for-futures branch October 26, 2023 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Codegen for futures.
2 participants