Merge pull request #215 from ProximaEPFL/fix-challenge-repository

Fix challenge repository crash when no available challenge
ProximaEPFL · May 3, 2024 · 6b9a59f · 6b9a59f
2 parents 4236edc + 2eb2322
commit 6b9a59f
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 5 deletions.
diff --git a/lib/services/database/challenge_repository_service.dart b/lib/services/database/challenge_repository_service.dart
@@ -144,6 +144,12 @@ class ChallengeRepositoryService {
 
     final Iterable<PostIdFirestore> possiblePosts =
         await _inRangeUnsortedPosts(pos, excludedUser);
+
+    // The whereIn argument of the where method crashed
+    // if the query is empty for the real firestore. This
+    // cannot be tested with the mock firestore.
+    if (possiblePosts.isEmpty) return;
+
     final Iterable<String> possiblePostsStringIds =
         possiblePosts.map((post) => post.value);
 

diff --git a/lib/views/home_content/challenge/challenge_list.dart b/lib/views/home_content/challenge/challenge_list.dart
@@ -11,16 +11,22 @@ class ChallengeList extends ConsumerWidget {
   Widget build(BuildContext context, WidgetRef ref) {
     final asyncChallenges = ref.watch(challengeProvider);
 
+    Widget emptyChallenge = const Center(
+      child: Text("No challenge available here!"),
+    );
+
     return CircularValue(
       value: asyncChallenges,
       builder: (context, challenges) {
         return RefreshIndicator(
           onRefresh: () => ref.read(challengeProvider.notifier).refresh(),
-          child: ListView(
-            children: challenges
-                .map((challenge) => ChallengeCard(challenge))
-                .toList(),
-          ),
+          child: challenges.isEmpty
+              ? emptyChallenge
+              : ListView(
+                  children: challenges
+                      .map((challenge) => ChallengeCard(challenge))
+                      .toList(),
+                ),
         );
       },
     );