Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test account and comment validation #358

Merged
merged 6 commits into from
May 29, 2024
Merged

Test account and comment validation #358

merged 6 commits into from
May 29, 2024

Conversation

TheTexanCodeur
Copy link
Collaborator

@TheTexanCodeur TheTexanCodeur commented May 29, 2024 •
edited by CHOOSEIT
Loading

This small PR tests hashcode and equality overrides that were not covered until now.

Acceptance criteria:

  • Test the hashcode override for the classes CreateAccountValidation and NewCommentValidation
  • Test the equality override for the classes CreateAccountValidation and NewCommentValidation

@TheTexanCodeur TheTexanCodeur self-assigned this May 29, 2024
@TheTexanCodeur TheTexanCodeur linked an issue May 29, 2024 that may be closed by this pull request
Add more tests #355
Closed
2 tasks
CHOOSEIT
CHOOSEIT requested changes May 29, 2024
View reviewed changes
Copy link
Member

@CHOOSEIT CHOOSEIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 💯

Looks good to me.

I just have a two little comments.

Thank you 👍🏼

test/models/ui/validation/create_account_validation_test.dart Show resolved Hide resolved
test/models/ui/validation/new_comment_validation_test.dart Show resolved Hide resolved
@TheTexanCodeur TheTexanCodeur requested a review from CHOOSEIT May 29, 2024 12:25
CHOOSEIT
CHOOSEIT approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@CHOOSEIT CHOOSEIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍🏼

@TheTexanCodeur TheTexanCodeur merged commit ff0f327 into main May 29, 2024
3 checks passed
@TheTexanCodeur TheTexanCodeur deleted the test-account-and-comment-validation branch May 29, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CHOOSEIT CHOOSEIT CHOOSEIT approved these changes

Assignees

@TheTexanCodeur TheTexanCodeur

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add more tests
2 participants
@TheTexanCodeur @CHOOSEIT