Add cookies #111
Draft
Add cookies #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
yenanw
commented
May 11, 2022
•
yenanw
commented
- Code is now saved as cookies
- Dark theme is now also saved as cookies
✅ Deploy Preview for learnypy ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
verasve
approved these changes
May 11, 2022
It depends. The laws are all over the place from what I've read. But what I gathered you always need to have consent when it's collecting personal data, which it does not. But you also need consent if the cookies collected are not essential to the website (eg the cookies aren't needed for the website to function). It can be argued that cookes in this case is essential to the website, but it can also be argued that they are not. But I would think we are in the clear without having the user to consent |
|
Aite put this PR on hold until the issue with GDPR is resolved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.