Skip to content

Commit

Permalink
Replaced #[allow()]'s with #[expect()]
Browse files Browse the repository at this point in the history
  • Loading branch information
DaniD3v committed Sep 6, 2024
1 parent e08309a commit 12e3732
Show file tree
Hide file tree
Showing 12 changed files with 18 additions and 18 deletions.
2 changes: 1 addition & 1 deletion pumpkin-protocol/src/client/play/c_login.rs
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ pub struct CLogin<'a> {
}

impl<'a> CLogin<'a> {
#[allow(clippy::too_many_arguments)]
#[expect(clippy::too_many_arguments)]
pub fn new(
entity_id: i32,
is_hardcore: bool,
Expand Down
2 changes: 1 addition & 1 deletion pumpkin-protocol/src/client/play/c_particle.rs
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ pub struct CParticle<'a> {
}

impl<'a> CParticle<'a> {
#[allow(clippy::too_many_arguments)]
#[expect(clippy::too_many_arguments)]
pub fn new(
long_distance: bool,
x: f64,
Expand Down
2 changes: 1 addition & 1 deletion pumpkin-protocol/src/client/play/c_player_chat_message.rs
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ pub struct CPlayerChatMessage<'a> {
}

impl<'a> CPlayerChatMessage<'a> {
#[allow(clippy::too_many_arguments)]
#[expect(clippy::too_many_arguments)]
pub fn new(
sender: UUID,
index: VarInt,
Expand Down
2 changes: 1 addition & 1 deletion pumpkin-protocol/src/client/play/c_spawn_player.rs
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ pub struct CSpawnEntity {
}

impl CSpawnEntity {
#[allow(clippy::too_many_arguments)]
#[expect(clippy::too_many_arguments)]
pub fn new(
entity_id: VarInt,
entity_uuid: UUID,
Expand Down
6 changes: 3 additions & 3 deletions pumpkin-world/src/chunk.rs
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ pub struct ChunkHeightmaps {
}

#[derive(Deserialize, Debug)]
#[allow(dead_code)]
#[expect(dead_code)]
struct ChunkSection {
#[serde(rename = "Y")]
y: i32,
Expand All @@ -64,7 +64,7 @@ struct ChunkSection {
#[derive(Deserialize, Debug)]
#[serde(rename_all = "PascalCase")]
struct ChunkNbt {
#[allow(dead_code)]
#[expect(dead_code)]
data_version: usize,

#[serde(rename = "sections")]
Expand Down Expand Up @@ -171,7 +171,7 @@ impl ChunkBlocks {
index.y.get_absolute() as usize * CHUNK_AREA + *index.z as usize * 16 + *index.x as usize
}

#[allow(dead_code)]
#[expect(dead_code)]
fn calculate_heightmap(&self) -> ChunkHeightmaps {
// figure out how LongArray is formatted
// figure out how to find out if block is motion blocking
Expand Down
4 changes: 2 additions & 2 deletions pumpkin-world/src/item/item_registry.rs
Original file line number Diff line number Diff line change
Expand Up @@ -28,12 +28,12 @@ pub struct ItemElement {
components: ItemComponents,
}

#[allow(dead_code)]
#[expect(dead_code)]
pub fn get_item_element(item_id: &str) -> &ItemComponents {
&ITEMS.get(item_id).expect("Item not found").components
}

#[allow(dead_code)]
#[expect(dead_code)]
pub fn get_item_protocol_id(item_id: &str) -> u32 {
global_registry::get_protocol_id(ITEM_REGISTRY, item_id)
}
2 changes: 1 addition & 1 deletion pumpkin-world/src/level.rs
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ pub struct Level {
}

struct SaveFile {
#[allow(dead_code)]
#[expect(dead_code)]
root_folder: PathBuf,
region_folder: PathBuf,
}
Expand Down
2 changes: 1 addition & 1 deletion pumpkin-world/src/world_gen/seed.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
use std::hash::{DefaultHasher, Hash, Hasher};

#[allow(dead_code)]
#[expect(dead_code)]
#[derive(Clone, Copy)]
pub struct Seed(pub i64);

Expand Down
6 changes: 3 additions & 3 deletions pumpkin/src/client/authentication.rs
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ use uuid::Uuid;
use crate::server::Server;

#[derive(Deserialize, Clone, Debug)]
#[allow(non_snake_case)]
#[allow(dead_code)]
#[expect(non_snake_case)]
#[expect(dead_code)]
pub struct ProfileTextures {
timestamp: i64,
profileId: Uuid,
Expand All @@ -24,7 +24,7 @@ pub struct ProfileTextures {
}

#[derive(Deserialize, Clone, Debug)]
#[allow(dead_code)]
#[expect(dead_code)]
pub struct Texture {
url: String,
metadata: Option<HashMap<String, String>>,
Expand Down
4 changes: 2 additions & 2 deletions pumpkin/src/commands/cmd_gamemode.rs
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ pub(crate) fn init_command_tree<'a>() -> CommandTree<'a> {
)));
} else {
// TODO
#[allow(clippy::let_underscore_future)]
#[expect(clippy::let_underscore_future)]
let _ = target.set_gamemode(gamemode);
target.send_system_message(TextComponent::text(&format!(
"Game mode was set to {:?}",
Expand All @@ -97,7 +97,7 @@ pub(crate) fn init_command_tree<'a>() -> CommandTree<'a> {
)));
} else {
// TODO
#[allow(clippy::let_underscore_future)]
#[expect(clippy::let_underscore_future)]
let _ = target.set_gamemode(gamemode);
target.send_system_message(TextComponent::text(&format!(
"Game mode was set to {:?}",
Expand Down
2 changes: 1 addition & 1 deletion pumpkin/src/commands/tree_builder.rs
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ impl<'a> NonLeafNodeBuilder<'a> {
}

/// Matches a sting literal.
#[allow(dead_code)] // todo: remove (so far no commands requiring this are implemented)
#[expect(dead_code)] // todo: remove (so far no commands requiring this are implemented)
pub fn literal(string: &str) -> NonLeafNodeBuilder {
NonLeafNodeBuilder {
node_type: NodeType::Literal { string },
Expand Down
2 changes: 1 addition & 1 deletion pumpkin/src/main.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#![allow(clippy::await_holding_lock)]
#![expect(clippy::await_holding_lock)]

#[cfg(target_os = "wasi")]
compile_error!("Compiling for WASI targets is not supported!");
Expand Down

0 comments on commit 12e3732

Please sign in to comment.