Remove unused deps

to mention is the take_mut dep i removed. Its heavily outdated and uses unsafe combined with pointer magic.

pumpkin-entity/Cargo.toml

@@ -4,7 +4,4 @@ version.workspace = true
 edition.workspace = true
 
 [dependencies]
-pumpkin-core = { path = "../pumpkin-core"}
-
-num-traits = "0.2"
-num-derive = "0.4"
+pumpkin-core = { path = "../pumpkin-core"}

pumpkin-protocol/Cargo.toml

@@ -13,8 +13,6 @@ bytes = "1.7"
 uuid.workspace = true
 
 serde.workspace = true
-# to parse strings to json responses
-serde_json = "1.0"
 
 flate2 = "1.0.33"
 
@@ -26,6 +24,6 @@ num-derive = "0.4"
 # encryption
 aes = "0.8.4"
 cfb8 = "0.8.1"
-take_mut = "0.2.2"
+
 itertools = "0.13.0"
 fastnbt = { git = "https://github.com/owengage/fastnbt.git" }

pumpkin-protocol/src/bytebuf/packet_id.rs

@@ -83,12 +83,13 @@ where
     P: Packet + Serialize,
 {
     fn write(&self, bytebuf: &mut ByteBuffer) {
-        take_mut::take(bytebuf, |bytebuf| {
-            let mut serializer = serializer::Serializer::new(bytebuf);
-            self.serialize(&mut serializer)
-                .expect("Could not serialize packet");
-            serializer.into()
-        });
+        let mut serializer = serializer::Serializer::new(ByteBuffer::empty());
+        self.serialize(&mut serializer)
+            .expect("Could not serialize packet");
+        // We write the packet in an empty bytebuffer and then put it into our current one.
+        // In the future we may do packet batching thats the reason i don't let every packet create a new bytebuffer and use
+        // an existing instead
+        bytebuf.put(serializer.output.buf());
     }
 }
 

pumpkin-protocol/src/bytebuf/serializer.rs

@@ -9,7 +9,7 @@ use thiserror::Error;
 use super::ByteBuffer;
 
 pub struct Serializer {
-    output: ByteBuffer,
+    pub output: ByteBuffer,
 }
 
 impl Serializer {

pumpkin-registry/src/lib.rs

@@ -33,12 +33,12 @@ impl Registry {
             registry_id: "minecraft:worldgen/biome".to_string(),
             registry_entries: vec![
                 RegistryEntry {
-                    entry_id: "minecraft:snowy_taiga",
+                    entry_id: "minecraft:plains",
                     data: fastnbt::to_bytes_with_opts(&Biome::default(), SerOpts::network_nbt())
                         .unwrap(),
                 },
                 RegistryEntry {
-                    entry_id: "minecraft:plains",
+                    entry_id: "minecraft:snowy_taiga",
                     data: fastnbt::to_bytes_with_opts(&Biome::default(), SerOpts::network_nbt())
                         .unwrap(),
                 },

pumpkin-world/src/biome.rs

@@ -1,9 +1,11 @@
 use serde::{Deserialize, Serialize};
 
 // TODO make this work with the protocol
+// Send by the registry
 #[derive(Serialize, Deserialize, Clone, Copy)]
 #[non_exhaustive]
 pub enum Biome {
     Plains,
+    SnowyTiga,
     // TODO list all Biomes
 }

pumpkin-world/src/level.rs

@@ -277,7 +277,7 @@ impl Level {
         match compression {
             Compression::Gzip => {
                 let mut z = GzDecoder::new(&compressed_data[..]);
-                let mut chunk_data = Vec::new();
+                let mut chunk_data = Vec::with_capacity(compressed_data.len());
                 match z.read_to_end(&mut chunk_data) {
                     Ok(_) => {}
                     Err(e) => {
@@ -288,7 +288,7 @@ impl Level {
             }
             Compression::Zlib => {
                 let mut z = ZlibDecoder::new(&compressed_data[..]);
-                let mut chunk_data = Vec::new();
+                let mut chunk_data = Vec::with_capacity(compressed_data.len());
                 match z.read_to_end(&mut chunk_data) {
                     Ok(_) => {}
                     Err(e) => {

pumpkin/Cargo.toml

@@ -21,7 +21,6 @@ pumpkin-registry = { path = "../pumpkin-registry"}
 # config
 serde.workspace = true
 serde_json = "1.0"
-toml = "0.8"
 
 bytes = "1.7"
 
@@ -59,7 +58,6 @@ log.workspace = true
 
 # networking
 mio = { version = "1.0.2", features = ["os-poll", "net"]}
-crossbeam-channel = "0.5.13"
 
 uuid.workspace = true
 tokio.workspace = true