Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github link in /pumpkin command #372

Merged
merged 18 commits into from
Dec 16, 2024
Merged

Conversation

lucas11222
Copy link
Contributor

@lucas11222 lucas11222 commented Dec 4, 2024

Add a text that says Github Repository and if you click it opens the github,
https://snowiiii.github.io/Pumpkin/

Testing

https://github.com/user-attachments/assets/60d6400b-e1d5-4f0d-bf9b-1882571729c2
Captura de pantalla 2024-12-04 175405

Checklist

Things need to be done before this Pull Request can be merged.

  • Code is well-formatted and adheres to project style guidelines: cargo fmt
  • Code does not produce any clippy warnings: cargo clippy
  • All unit tests pass: cargo test
  • [?] I added new unit tests, so other people don't accidentally break my code by changing other parts of the codebase. How?

@lucas11222 lucas11222 marked this pull request as draft December 4, 2024 19:41
@lucas11222
Copy link
Contributor Author

wating for #370

@lucas11222
Copy link
Contributor Author

im wating that command traker pr finish

@lucas11222 lucas11222 marked this pull request as ready for review December 5, 2024 13:54
@lucas11222
Copy link
Contributor Author

Command traker pr is merged soo now we can merge this one

@lucas11222
Copy link
Contributor Author

WHY IS STILL CONFITING

@lucas11222
Copy link
Contributor Author

fixed

@Snowiiii
Copy link
Member

Snowiiii commented Dec 5, 2024

There is no pupkin command

@lucas11222
Copy link
Contributor Author

There is no pupkin command

sorry typo i mean pumpkin

@lucas11222 lucas11222 changed the title Github link in /pupkin command Github link in /pumpkin command Dec 5, 2024
.gitignore Outdated Show resolved Hide resolved
@Snowiiii
Copy link
Member

Snowiiii commented Dec 6, 2024

I have to say that i don't really like the design of the current Text. It has no space between the main text and also uses a new color (i think 3 colors are too much for this little sentence

@lucas11222
Copy link
Contributor Author

I have to say that i don't really like the design of the current Text. It has no space between the main text and also uses a new color (i think 3 colors are too much for this little sentence

oh sorry its formating that delets the spaces for the text idk why

@lucas11222
Copy link
Contributor Author

I have to say that i don't really like the design of the current Text. It has no space between the main text and also uses a new color (i think 3 colors are too much for this little sentence

1: the screenshot is old, i fixed the spaces. the color someone gave me a tip for the text putting it blue

@Snowiiii
Copy link
Member

Snowiiii commented Dec 7, 2024

I have to say that i don't really like the design of the current Text. It has no space between the main text and also uses a new color (i think 3 colors are too much for this little sentence

1: the screenshot is old, i fixed the spaces. the color someone gave me a tip for the text putting it blue

image

The hovering is also a bit broken, when you are between the spaces it says to copy the server version otherwise the docs or repo

@lucas11222
Copy link
Contributor Author

I have to say that i don't really like the design of the current Text. It has no space between the main text and also uses a new color (i think 3 colors are too much for this little sentence

1: the screenshot is old, i fixed the spaces. the color someone gave me a tip for the text putting it blue

image

The hovering is also a bit broken, when you are between the spaces it says to copy the server version otherwise the docs or repo

thats wirld that dosent happen to me

@lucas11222
Copy link
Contributor Author

after a LONG TIME becuse i forgot this pull request i fixed the bug

@Snowiiii
Copy link
Member

Overall looks okay. Still not be biggest fan of the design but it does its Job.
Thank you @lucas11222 👍

@Snowiiii Snowiiii merged commit 9a2e68a into Pumpkin-MC:master Dec 16, 2024
9 checks passed
@lucas11222
Copy link
Contributor Author

Overall looks okay. Still not be biggest fan of the design but it does its Job. Thank you @lucas11222 👍

No poblem! yea i suck at design xd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants