Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
cd6ac14 introduced a regression where CPU intensive tasks are not performed by all CPUs. This is because the rayon pool does not queue tasks until the current task is complete and because the tokio runtime never ends we effectively lose a CPU.
Additionally, the root cause of the tokio runtime choking is because we were waiting for the results of the rayon pool directly from the tokio runtime, blocking it, which obviously defeats the purpose.
This PR fixes these issues, sorts initial spawn chunks so that rayon processes them in rings rather than slices, and adds a note in CONTRIBUTING.md on how to avoid issues like this in the future.
Testing
Joined the server in debug mode and ran commands while chunks loaded
Checklist
Things need to be done before this Pull Request can be merged.
cargo fmt
cargo clippy
cargo test