Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly check chunks on respawn, render distance update, and validate render distance #398

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

kralverde
Copy link
Contributor

Description

This PR properly updates watched chunks on respawn and render distance updates. It also validates the render distance sent, kicking the player if it is negative.

Testing

Joined a world and:

  • updated render distances
  • died and respawned
    then validated chunks would load/unload and leave the cache properly.

Checklist

Things need to be done before this Pull Request can be merged.

  • Code is well-formatted and adheres to project style guidelines: cargo fmt
  • Code does not produce any clippy warnings: cargo clippy
  • All unit tests pass: cargo test

@Snowiiii
Copy link
Member

Looks good.
Thanks @kralverde :D

@Snowiiii Snowiiii merged commit c285915 into Pumpkin-MC:master Dec 16, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants