Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make command dispatcher mutable #405

Merged
merged 1 commit into from
Dec 25, 2024

Conversation

kralverde
Copy link
Contributor

Description

Makes the command dispatcher mutable via tokio RWLock as a part of the Server struct

There is also a massive over usage of lifetimes in the command codebase that makes it overly constraining. This will not be addressed in this PR.

Testing

Opened the console and ran commands

Checklist

Things need to be done before this Pull Request can be merged.

  • Code is well-formatted and adheres to project style guidelines: cargo fmt
  • Code does not produce any clippy warnings: cargo clippy
  • All unit tests pass: cargo test
  • I added new unit tests, so other people don't accidentally break my code by changing other parts of the codebase. How?

@vyPal
Copy link
Contributor

vyPal commented Dec 22, 2024

imo looks good, do you want to merge this independently and I will just sync the changes with the plugins branch, or should I try to copy these changes and have them as part of the plugins merge request when it's ready?

@kralverde
Copy link
Contributor Author

Im fine with merging as-is, I havent done a whole lot of testing to make sure i havent broke anything tho..

@kralverde kralverde marked this pull request as ready for review December 22, 2024 17:21
@Snowiiii
Copy link
Member

Looks good, After testing some commands including /help and i haven't found any bugs.
Thanks @kralverde

@Snowiiii Snowiiii merged commit 0e9b1af into Pumpkin-MC:master Dec 25, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants