Create configs in a folder #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pumpkin-config/src/lib.rs
Outdated
| @@ -126,26 +128,33 @@ trait LoadConfiguration { | |||
| where | |||
| Self: Sized + Default + Serialize + DeserializeOwned, | |||
| { | |||
| let path = Self::get_path(); | |||
| let exe_path = env::current_exe().unwrap(); | |||
There was a problem hiding this comment.
In docker, the config folder is created in /bin, something is wrong!
It should not use current_exe as base path, instead use CWD see env::current_dir()
There was a problem hiding this comment.
Makes sense, did not saw that. Can you may test it again with the latest change
|
Maybe we should make it possible to change the path via CLI args or/and env vars. |
|
Now it works how it should be, config folder inside data volume |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Creates configuration files in a separate folder which then can be in a read-only mode.
Addresses #377
Testing
Linux: Changed config values and saw that the server detected the new values
Docker
Checklist
Things need to be done before this Pull Request can be merged.
cargo fmtcargo clippycargo test