-
-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Pick item (Middle Mouse Click) #418
Open
Bafran
wants to merge
10
commits into
Pumpkin-MC:master
Choose a base branch
from
Bafran:pick_item
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+155
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current progress - general structure is in place but crashes upon middle mouse click because the item stack comes back as none |
After testing i noticed that when you pick a block you already have in your hotbar you get another one, This is not vanilla behaviour. You should check if the player already has the block in this hotbar and when yes just switch to it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue #397
Adding Pick Item (Middle Mouse Click). In survival, searches inventory and brings the item to the appropriate hotbar slot if available. In creative, sets the hotbar slot or grabs the item as appropriate.
Todo is adding pick item from entity. A placeholder was left however I don't believe /spawn and spawn eggs are implemented so I didn't have a way of testing on mobs and left that work as a todo.
Testing
Checklist
Things need to be done before this Pull Request can be merged.
cargo fmt
cargo clippy
cargo test
Documentation
I literally could not get the actual docs to load so these are links to internet archive
Pick Item
Set Creative Mode Slot