Remove unnecessary lifetimes in CommandDispatcher and Command #419
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a small change aiming to make the usage of CommandDispatcher a little bit easier by removing all of the unnecessary lifetimes. It changes all borrowed strings in CommandDispatcher to oned ones, it also replaces all refrences to dyn traits with Arcs. Both these changes have a small preformence impact, specifically when cloning, but it should be negligable considering they arent cloned alot. if needed i cant also swap the owned strings to Arc, which could be a bit faster with frequent cloning.
Testing
There currently aren't any unit tests for commands so i have no way of verifying whether everything worked as expected now or before.
Checklist
Things need to be done before this Pull Request can be merged.
cargo fmt
cargo clippy
cargo test
I added new unit tests, so other people don't accidentally break my code by changing other parts of the codebase. How?(not needed, this doesnt change any logic)