Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added basic chest opening and closing #421

Merged
merged 4 commits into from
Dec 28, 2024

Conversation

OfficialKris
Copy link
Contributor

@OfficialKris OfficialKris commented Dec 27, 2024

Description

Added chest opening and closing animation and only trigger sound when the first or last player does the correct action.

Testing

Two clients:

  • Place one chest, open and close, see animation in both and notice sound
  • Open in second client, close in first, stays open and no sound
  • Close in both, it closes and plays a sound

This does not add the constant ticks and also sends all chest packets to all players instead of just when the respective chunks are loaded. Both of these issues would be separate PRs.

Checklist

Things need to be done before this Pull Request can be merged.

  • Code is well-formatted and adheres to project style guidelines: cargo fmt
  • Code does not produce any clippy warnings: cargo clippy
  • All unit tests pass: cargo test
  • I added new unit tests, so other people don't accidentally break my code by changing other parts of the codebase. How?

@OfficialKris OfficialKris marked this pull request as ready for review December 28, 2024 05:57
@Snowiiii Snowiiii merged commit ad2fd3c into Pumpkin-MC:master Dec 28, 2024
9 checks passed
@Snowiiii
Copy link
Member

Merged, Big thanks for your work @OfficialKris 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants