Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add egg-pumpkin.json #425

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add egg-pumpkin.json #425

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5025c25
Add egg-pumpkin.json
Commandcracker Dec 27, 2024
696c59e
Apply requested cahnges
Commandcracker Dec 27, 2024
9a4f0b1
Add email and fallback for cargo jobs
Commandcracker Dec 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
82 changes: 82 additions & 0 deletions egg-pumpkin.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,82 @@
{
"_comment": "DO NOT EDIT: FILE GENERATED AUTOMATICALLY BY PTERODACTYL PANEL - PTERODACTYL.IO",
"meta": {
"version": "PTDL_v2",
"update_url": null
},
"exported_at": "2024-12-27T22:08:25+01:00",
"name": "pumpkin",
"author": "[email protected]",
Commandcracker marked this conversation as resolved.
Show resolved Hide resolved
"description": "Pumpkin is a Minecraft server built entirely in Rust, offering a fast, efficient, and customizable experience. It prioritizes performance and player enjoyment while adhering to the core mechanics of the game. Requires around 2GB RAM to build, adjust docker.installer_limits.memory in your wing accordingly! Currently, you need to adjust the port in the config manually!",
"features": null,
"docker_images": {
"Alpine": "ghcr.io\/pterodactyl\/yolks:alpine"
},
"file_denylist": [],
"startup": ".\/pumpkin",
"config": {
"files": "{}",
"startup": "{}",
Commandcracker marked this conversation as resolved.
Show resolved Hide resolved
"logs": "{}",
"stop": "stop"
},
"scripts": {
"installation": {
"script": "#!\/bin\/ash\r\nset -eux\r\n\r\napk add --no-cache musl-dev git\r\nmkdir -p \/mnt\/server\r\n\r\nREPO_URL=\"${GIT_URL:-https:\/\/github.com\/Snowiiii\/Pumpkin.git}\"\r\n\r\nif [ -n \"$GIT_BRANCH\" ]; then\r\n git clone --depth 1 --single-branch --branch \"$GIT_BRANCH\" \"$REPO_URL\"\r\nelse\r\n git clone --depth 1 --single-branch \"$REPO_URL\"\r\nfi\r\n\r\nif [ -n \"$GIT_COMMIT\" ]; then\r\n git checkout \"$GIT_COMMIT\"\r\nfi\r\n\r\ncd Pumpkin\r\n\r\nif [[ \"$BUILD_RELEASE\" == \"1\" || \"$BUILD_RELEASE\" == \"true\" ]]; then\r\n cargo build --release\r\n strip target\/release\/pumpkin\r\n cp target\/release\/pumpkin \/mnt\/server\/pumpkin\r\nelse\r\n cargo build\r\n cp target\/debug\/pumpkin \/mnt\/server\/pumpkin\r\nfi",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This cargo build command will build a generic image, since this will most likely be deployed on server with one specific set of hardware we can add additional instructions to optimize for this server's hardware. Through setting the following environment variables:

RUSTFLAGS="-C target-feature=-crt-static -C target-cpu=native"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably need to tweak the images a bit

Error loading shared library libgcc_s.so.1: No such file or directory (needed by ./pumpkin)
Error relocating ./pumpkin: _Unwind_Resume: symbol not found
Error relocating ./pumpkin: _Unwind_GetTextRelBase: symbol not found
Error relocating ./pumpkin: _Unwind_GetIPInfo: symbol not found
Error relocating ./pumpkin: _Unwind_GetIP: symbol not found
Error relocating ./pumpkin: _Unwind_SetGR: symbol not found
Error relocating ./pumpkin: _Unwind_GetLanguageSpecificData: symbol not found
Error relocating ./pumpkin: _Unwind_Backtrace: symbol not found
Error relocating ./pumpkin: _Unwind_GetRegionStart: symbol not found
Error relocating ./pumpkin: _Unwind_SetIP: symbol not found
Error relocating ./pumpkin: _Unwind_RaiseException: symbol not found
Error relocating ./pumpkin: _Unwind_GetDataRelBase: symbol not found
Error relocating ./pumpkin: _Unwind_DeleteException: symbol not found

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, I was honestly wondering on if the pumpkin executable could run without libgcc. I guess this answers that.

What we'd need to do is provide our own runtime container with libgcc installed. I had done that in my own repository for a pumpkin egg however I didn't bother building an ARM64 variant. Which the alpine yolk has.

@Snowiiii would you be fine with adding another container image for Pumpkin to run on Pterodactyl?
Probably tagged along the lines of ghcr.io/snowiiii/pumpkin:yolk.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So as of my understanding, We then have 2 images. One without libgcc, And one with libgcc packaged ?. Isn't there a way to just install libgcc in the script ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At best 3 images

  1. normal pumpkin on alpine
  2. yolk based on ghcr.io/pterodactyl/yolks:alpine
  3. installer based on ghcr.io/pterodactyl/installers:alpine

(and maybe add a scratch and Debian image later on)

"container": "docker.io\/rust:1-alpine3.21",
"entrypoint": "ash"
}
},
"variables": [
Commandcracker marked this conversation as resolved.
Show resolved Hide resolved
{
"name": "Rust backtrace",
"description": "\"0\" -> No backtrace is generated. This is the default behavior.\r\n\"1\" -> Generates a minimal backtrace showing only relevant information about where the panic occurred.\r\n\"full\" -> Generates a detailed backtrace, showing all frames leading to the panic, including functions in the Rust standard library and dependencies.",
"env_variable": "RUST_BACKTRACE",
"default_value": "1",
"user_viewable": true,
"user_editable": true,
"rules": "required|in:1,0,full",
"field_type": "text"
},
{
"name": "Build Release",
"description": "Either build release or a debug build of pumpkin.\r\nScope: installation",
"env_variable": "BUILD_RELEASE",
"default_value": "1",
"user_viewable": true,
"user_editable": true,
"rules": "required|boolean",
"field_type": "text"
},
{
"name": "Git commit",
"description": "Chose which git commit to clone.\r\nScope: installation",
"env_variable": "GIT_COMMIT",
"default_value": "",
"user_viewable": true,
"user_editable": true,
"rules": "nullable|string|max:40|min:7",
"field_type": "text"
},
{
"name": "Git branch",
"description": "Chose which git branch to clone.\r\nScope: installation",
"env_variable": "GIT_BRANCH",
"default_value": "",
"user_viewable": true,
"user_editable": true,
"rules": "nullable|string|max:255",
"field_type": "text"
},
{
"name": "Git URL",
"description": "Chose which git URL to clone from. Useful if you are using a fork.\r\nScope: installation",
"env_variable": "GIT_URL",
"default_value": "",
"user_viewable": true,
"user_editable": true,
"rules": "nullable|string",
"field_type": "text"
}
]
}
Loading