Refactor global block container system #427
Open
+323
−382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vements # Conflicts: # pumpkin-core/src/math/position.rs # pumpkin-inventory/src/lib.rs # pumpkin-inventory/src/open_container.rs # pumpkin/src/block/blocks/chest.rs # pumpkin/src/block/blocks/crafting_table.rs # pumpkin/src/block/blocks/furnace.rs # pumpkin/src/block/pumpkin_block.rs # pumpkin/src/net/packet/play.rs # pumpkin/src/server/mod.rs
Bryntet
force-pushed
the
fork/OfficialKris/global-inventories-improvements
branch
from
cb728c8 to
a2ea3cc
Compare
|
Looks great @Bryntet! Love how all the todos got resolved! Very nice system |
|
Thanks! |
|
When tested the server freezed when i was trying to open a chest, I think this is the same issue as in #388 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed and made things more generic and easily extendable with traits.
Description
Testing
Checklist
Things need to be done before this Pull Request can be merged.
cargo fmtcargo clippycargo test