Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: command permission handling #428

Merged

Conversation

smuu
Copy link
Contributor

@smuu smuu commented Dec 29, 2024

Description

This PR introduced the following:

  • When registering a new command, one must specify the permission level
  • If a player tries to execute a command without having permission, it will show that to the player
  • When a player wants to autocomplete a command without having permission, it will not show in the autocomplete

Closes #424

Testing

Checklist

Things need to be done before this Pull Request can be merged.

  • Code is well-formatted and adheres to project style guidelines: cargo fmt
  • Code does not produce any clippy warnings: cargo clippy
  • All unit tests pass: cargo test
  • I added new unit tests, so other people don't accidentally break my code by changing other parts of the codebase. How?

@Snowiiii
Copy link
Member

Works great, Great work. Thanks for your first Pull request @smuu 🚀

@Snowiiii Snowiiii merged commit 2d136b1 into Pumpkin-MC:master Dec 29, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Command permission message
2 participants