Update CONTRIBUTING.md #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The message was a bit to vague before
Luk-ESC
reviewed
Aug 22, 2024
CONTRIBUTING.md
Outdated
| @@ -22,7 +22,7 @@ There are several ways you can contribute to Pumpkin: | |||
| If you'd like to contribute code changes, fork the Pumpkin repository on GitHub. | |||
| Install Rust at [rust-lang.org](https://www.rust-lang.org/). | |||
| Make your changes on your local fork and create a pull request to the main repository. | |||
| Ensure your code adheres to the project's coding style guidelines (if any). | |||
| Ensure your code adheres to our project structure and style guidlines. | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
fixed :) |
|
You say "The message was a bit too vague before", this does not address that. Right now "Our project structure and style guidelines" isn't actually defined in this document (and only structure is defined elsewhere, in A better fix, that would make this less vague, is to link to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The message was a bit to vague before