Created Identifier to help keep track of plugin resources. #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snowiiii
reviewed
Sep 1, 2024
…nt-api Resolve merge conflicts
|
I have moved serde into the workspace as well |
|
Okay looks good then, Thank you @neeleshpoli |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created Identifier to help keep track of plugin resources.
Use cases:
Serde was added so that structs can be serialized and deserialized when transporting between plugin and server. Currently message pack is used, but protocol buffers should be used in the future due to smaller size and efficiency. The only reason why protocol buffers are not used right now is because it requires some work to setup.