start work on noise for chunk generation #90
Conversation
|
Noises used in surface generation is done. Actual chunk population is more in-depth. I'll need to take a longer look at it all to see whats going on. |
|
I will review the rest. It shouldn't take more than an hour. |
|
About the inline, I recommend to take a look at https://gist.github.com/kvark/f067ba974446f7c5ce5bd544fe370186#dont-use-inlinealways |
Interesting resource. I assumed the inlining behavior was the same between Rust and other C compilers. Thank you for the sharing. I guess the inlining changes can be reverted if deemed necessary. |
|
Ok I may have been too optimistic, the review will take more than an hour. |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| ) | ||
| } | ||
|
|
||
| #[allow(dead_code)] |
There was a problem hiding this comment.
There is a large amount of #[allow(dead_code)] You would be better setting this at module level instead (#![allow(dead_code)])
There was a problem hiding this comment.
how best do you recommend doing this?
There was a problem hiding this comment.
should be good now?
|
Looks good. Thank you @kralverde ❤️ |
WIP
This PR aims to implement the noise and related methods used for chunk generation. The noise will generate the same values as the Java implementation given the same inputs.