-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: improve release #534
Conversation
WalkthroughThe recent updates streamline the release process by refining workflows, enhancing versioning, and improving release note templates. Key changes include renaming jobs, adjusting checkout steps, updating tag fetching, and modifying release note generation. The Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- .github/workflows/release.yml (1 hunks)
- .goreleaser.yml (7 hunks)
- Makefile (3 hunks)
- contrib/scripts/release-note.sh (1 hunks)
Files skipped from review due to trivial changes (2)
- Makefile
- contrib/scripts/release-note.sh
Additional comments not posted (12)
.github/workflows/release.yml (6)
6-7
: Updated tag patterns to include both regular and RC versions. This is a good practice for handling different release stages.
14-17
: The modification to fetch all tags and history (fetch-depth: 0
) is a robust approach for workflows that depend on the entire git history.
18-19
: Adding a step to forcefully fetch tags enhances the reliability of the workflow by ensuring the latest tags are used.
20-23
: Improvements to the release note generation step (making the script executable and running it with the correct tag version) enhance the automation and accuracy of the process.
24-27
: Setting theGITHUB_TOKEN
explicitly in the environment configuration enhances security and manageability.
28-28
: Renaming the step to 'Release publish' improves clarity and maintainability of the workflow..goreleaser.yml (6)
8-8
: Simplifying the binary path across various build configurations helps avoid path-related errors and makes the build process cleaner.Also applies to: 24-24, 40-40, 56-56, 72-72
19-19
: Adding the-trimpath
flag enhances the privacy and security of the build by removing all file system paths from the compiled executable.Also applies to: 35-35, 51-51, 67-67, 83-83
21-21
: Updating the ldflags to include the version prefix and commit hash ensures that the build metadata is accurate and traceable.Also applies to: 37-37, 53-53, 69-69, 86-86
89-90
: Updating the naming templates for archives and checksums to include version and architecture details enhances the organization and retrievability of build artifacts.Also applies to: 93-94
97-97
: Adding a specific naming template for snapshots clearly distinguishes them from regular releases, which is useful for testing and development purposes.
107-123
: Enhancements to the release section, including detailed instructions for building from source and pulling Docker images, provide clear guidance for users on how to use the software.
Summary by CodeRabbit