fix: fix slice init length

[rusttech]

The intention here should be to initialize a slice with a capacity of len(state.Validators.Validators) rather than initializing the length of this slice.

The online demo: https://go.dev/play/p/q1BcVCmvidW

Summary by CodeRabbit

• Chores
  • Optimized memory usage in the handling of validators, allowing for dynamic growth of the validators list.
  • Updated test expectations for the number of consensus validators returned.

[coderabbitai]

Walkthrough

The changes in this pull request involve a modification to the GetConsensusValidators method within the Database struct located in server/database.go. The primary adjustment is the way the validators slice is initialized. Instead of pre-allocating the slice with a fixed length equal to the number of validators, it is now initialized with both a length and capacity of zero, allowing for dynamic growth as entries are added. This optimizes memory usage while maintaining the existing logic of the method.

Changes

File	Change Summary
server/database.go	Modified GetConsensusValidators method to initialize validators slice with zero length and capacity for dynamic growth.
server/database_test.go	Updated TestGetConsensusValidators method to change expected length of validators slice from 2 to 1.

Poem

In the server's quiet space,
A slice now finds its place.
With zero length, it starts anew,
Growing strong with each value true.
Memory saved, a gentle cheer,
For validators, we hold dear! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 141184a and 25662dd.

📒 Files selected for processing (1)

• server/database_test.go (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• server/database_test.go

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[fx0x55]

@rusttech Thank you for your contribution! We really appreciate your effort in submitting this PR. LGTM

[fx0x55]

@rusttech Could you please fix the TestGetConsensusValidators test? The expected validators length should be 1.

[rusttech]

@rusttech Could you please fix the TestGetConsensusValidators test? The expected validators length should be 1.

Of course. Modified.

Please review again.