change simpleyaml group #1364
Closed
change simpleyaml group #1364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Purpur doesn't add this dependency. You need to PR this upstream to the project that does, Pufferfish. If it is a valid concern, they will use it. If not, they will explain why it isn't. |
|
pufferfish-gg/Pufferfish#73 - did it here too as well just for expediency, in my mind was just a game of who does it first |
|
superceded by 07dbb3d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i'll eventually pr this to pufferfish as well but my workspace is struggling rn
something about the jitpack on this lib is goofed
https://jitpack.io/com/github/carleslc/Simple-YAML/Simple-Yaml/1.8.4/Simple-Yaml-1.8.4.pom exists
https://jitpack.io/me/carleslc/Simple-YAML/Simple-Yaml/1.8.4/Simple-Yaml-1.8.4.pom doesn't
this should let people build locally nicer
yaml issue - Carleslc/Simple-YAML#77