WIP: Add Notify support #39
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support manelizzard/flarum-notify when installed.
|
It seems that this PR includes changes for flarum beta 8, can you rebase into current master? Thank you! |
|
I added this to my to do list but I will not be able to work on this in next two months at least. PS I also started a large scale rewrite of the client side code in order to fix the 403 errors for unauthenticated users on beta 8 but the same time constraints apply. |
|
Thank you, and don't worry, there is no rush to merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support https://github.com/manelizzard/flarum-notify when installed.
At the moment I am attempting to add switch to the Notify panel in administration. It will require manelizzard/flarum-notify#10