Remove Multidex declaration #189
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the min SDK is 23, it is no longer necessary to use the Multidex library. It has been removed from this project, but it still depends on Robolectric's `shadows-multidex`, which is not necessary. See the following for more info: https://developer.android.com/build/multidex#mdex-on-l
MGaetan89
force-pushed
the
remove_multidex
branch
from
7b11bfb to
5e5988e
Compare
|
@MGaetan89 Thanks for submitting the PR! Sadly, this Github repo is only a partial copy of our internal repository, and our CI/CD will just overwrite any merges to the main branch whenever we do a new release. So won't be merging this PR, but the suggested changes were applied in the latest 6.7.16 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the min SDK is 23, it is no longer necessary to use the Multidex library.
It has been removed from this project, but it still depends on Robolectric's
shadows-multidex, which is not necessary.See the following for more info: https://developer.android.com/build/multidex#mdex-on-l