Fix CI/CL

[WyattBlue]

No description provided.

[jlaine]

Some points:

• one commit = one change, I'm not fond of "mixed bag" commits which change a whole bunch of things
• let's try to make commit message descriptive, that's all well have to go one in a year or more to understand why a change was made. "fix ci/cl" doesn't seem descriptive: you're abandoning support for FFmpeg prior to 5.1 aren't you?
• commented code is a code smell: either we want the code or we don't (we have the git history).
• I haven't looked into the detail but why comment out a failing test? It used to pass, if it doesn't it's a sign either the test needs redesigning or something has changed under our feet
• I'm not against style changes but ensure they are enforced by CI using an automated tool, preferably black + ruff

[WyattBlue]

@jlaine Your points are correct. I'm just trying to figure out why the tests are failing, then I'm clean up the PR.

[hmaarrfk]

I came here because I was curious to see the progress.

I learned that it is possible, if you want to have large style changes as this one, to ignore a specific commit in the git blame.

[jlaine]

@jlaine Your points are correct. I'm just trying to figure out why the tests are failing, then I'm clean up the PR.

Sounds good! Again kudos for the energy you're putting into this, don't get me wrong I'm very grateful for your involvement :)

[jlaine]

AFAICT the test that was "commented" is in fact test_doctests.py which is completely removed? Could we have the rationale for this and have it in a separate commit please?

What tool did you use to reformat the tests? Currently we run black, flake8 and isort (the two last ones might be replaced by ruff if it supports Cython code).

[WyattBlue]

black is not being applied to the tests directory.