fix: set default color range for VideoReformatter.format() #1458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elxy
force-pushed
the
fix/default_color_range
branch
from
64e5e14 to
609f36e
Compare
|
This reverts the fix to #1378 |
added 2 commits
July 17, 2024 10:07
In sws_setColorspaceDetails(), dstRange/srcRange is 1 for JPEG range and 0 for MPEG range.
elxy
force-pushed
the
fix/default_color_range
branch
from
609f36e to
87a5007
Compare
Thanks for the reminder. The description of parameters has been updated to match the implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behavior of the VideoReformatter.format() is inconsistent with the documentation. According to the documentation, when color_range is None, it should use the color_range of the frame. However, in the function implementation, the default is set to 0.