Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added E2E Test for MVC [TWP52] #327

Merged
merged 2 commits into from
Mar 13, 2024
Merged

Conversation

its-ChaTTy
Copy link
Contributor

@its-ChaTTy its-ChaTTy commented Mar 10, 2024

Summary

Added e2e test for MVC lecture (TWP52) for both English & Spanish. This PR is an extension to PR #322 .

Checklist

  • Variables, functions and comments are translated to Spanish
  • Functions follow underscore notation
  • Spell check done & typos fixed
  • All python code is PEP8 compliant
  • Test coverage with Playwright implemented; locators are Pyhton code
  • Reviewers assigned (all peers & at least 1 mentor)

Screenshots

image

Copy link

@fzuccolo
Copy link
Member

Hi @its-ChaTTy.

I see that the MVC lecture published from your branch does not render the buttons to run the code, so that may be the cause of the failing tests: http://pyar.github.io/PyZombis/327/lectures/TWP52.html

It should be rendered like this for the tests to pass: http://pyar.github.io/PyZombis/main/lectures/TWP52.html

Your fork seems outdated, try to update it and see if that fixes the build.

Copy link

@its-ChaTTy
Copy link
Contributor Author

Thanks for the review @fzuccolo, I have updated the fork now the tests should work as intended.

@NicolasSandoval
Copy link
Member

Thanks @its-ChaTTy.

@NicolasSandoval NicolasSandoval merged commit 43ced16 into PyAr:main Mar 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants