Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use safety scan instead of the deprecated safety check #2368

Closed
wants to merge 1 commit into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Feb 18, 2025

Should we drop safety or get a free API key?

The lint GitHub Action currently generates:

DEPRECATED: this command (check) has been DEPRECATED, and will be unsupported beyond 01 June 2024.

We highly encourage switching to the new scan command which is easier to use, more powerful, and can be set up to mimic the deprecated command if required.

- uv run safety check -i 72715 -i 51457 -i 59587
+ uv run safety scan -i 72715 -i 51457 -i 59587

https://docs.safetycli.com/safety-docs/safety-cli/migrating-from-safety-cli-2.x-to-safety-cli-3.x#switching-to-the-new-scan-command

Please login or register Safety CLI (free forever) to scan and secure your
projects with Safety
(R)egister for a free account in 30 seconds, or (L)ogin with an existing account
Unhandled exception happened: EOF when reading a line
to continue (R/L):

Copy link

codecov bot commented Feb 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.16%. Comparing base (6f29cb9) to head (5b50f99).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2368   +/-   ##
=======================================
  Coverage   99.16%   99.16%           
=======================================
  Files          40       40           
  Lines        3101     3101           
  Branches      680      680           
=======================================
  Hits         3075     3075           
  Misses         15       15           
  Partials       11       11           

@cclauss cclauss changed the title Use safety scan instead of the deprecated safety check Use safety scan instead of the deprecated safety check Feb 19, 2025
Copy link
Member

@DanielNoord DanielNoord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be okay with dropping it.

What do you think @staticdev?

@staticdev
Copy link
Collaborator

staticdev commented Feb 19, 2025

Me too.. Safety got also very bureaucratic unfortuntely.

@cclauss
Copy link
Contributor Author

cclauss commented Feb 21, 2025

Closing. safety can be removed when fails. It currently runs with a warning but might catch problems.

@cclauss cclauss closed this Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants