better error handling for managed site installations #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
MaturinBuildSettings
andMaturinDevelopSettings
removed in #11 I was concerned about what would happen if users are importing these classes insitecustomize.py
. Looking at the0.1.0
release, thepresets
option wasn't available so it's unlikely many user's installs will break.It seems that when something breaks in
sitecustomize.py
an error is printed but the interpreter continues. To help the user resolve the problem, managed installations now print a message informing the user how they can remove the installation to resolve the error:In future, if any maturin flags change and
MaturinSettings
changes to match, breakages could become more common so it is important to handle this case properly.