release: 0.20.3 #3882
Merged
release: 0.20.3 #3882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ck interpreter ID. I chose to make the dependency mandatory instead of optional as portable-atomic itself just forwards to the native atomics when they are available so making that choice part of our build system is not really necessary. Personally, I was unable to perceive any noticeable compile-time hit from adding it.
* add maximum Python version check * restore dependency of `pyo3-macros-backend` on `pyo3-build-config` * fix clippy-all noxfile job
* fix `either` feature conditional compilation, again * test feature powerset in CI * install `rust-src` for feature powerset tests * review: adamreichold feedback * Fix one more case of redundant imports. * just check feature powerset for now --------- Co-authored-by: Adam Reichold <[email protected]>
davidhewitt
force-pushed
the
release-0.20.3
branch
4 times, most recently
from
476ce65 to
71c07b3
Compare
davidhewitt
force-pushed
the
release-0.20.3
branch
from
71c07b3 to
901f54b
Compare
|
I think I will ignore the nightly lints and release. I tried a few times to tidy them but it's a lot and shouldn't be relevant for users as they're just about dead code and redundant imports, mostly in tests. |
|
Thanks a lot! |
|
No problem, I'm sorry again for the long delay in getting this shipped. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a long-overdue patch release which just resolves a few quality-of-life issues we hit over the time on PyO3 0.20's release cycle.
Despite my feeling that 0.21 is just around the corner, I think it's worth getting these issues with the 0.20 series resolved.
cc @mgorny - sorry this took so long!
If I hear no reason to delay, I'll put live tomorrow morning!