ffi: add FFI definition PyDateTime_CAPSULE_NAME
#4634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidhewitt
commented
Oct 19, 2024
Comment on lines
+622
to
+625
| #[inline] | ||
| pub unsafe fn PyDateTime_TimeZone_UTC() -> *mut PyObject { | ||
| (*PyDateTimeAPI()).TimeZone_UTC | ||
| } |
There was a problem hiding this comment.
Moved this down to match the order in the C header.
|
I'm going to merge this immediately so that #4623 can rebase cc @ngoldbaum 🙈 |
alex
approved these changes
Oct 19, 2024
alex
reviewed
Oct 19, 2024
davidhewitt
force-pushed
the
datetime-capsule-name
branch
from
b056850 to
4af0940
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing #4623 I realised that
PyDateTime_CAPSULE_NAMEwas a temporary allocation rather than a constant. It also wasn't exposed even though it is in the C header. So a tiny cleanup.