Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation on the consequences of NumPy matching C's integeer hierarchy. #405

Merged
merged 1 commit into from
Nov 11, 2023

Conversation

adamreichold
Copy link
Member

Closes #404

@adamreichold
Copy link
Member Author

@jeertmans Something like this?

@jeertmans
Copy link

Looks perfect @adamreichold, thanks! One last question: where would it reflect on the docs.rs pages? I don't see where the src/dtypes.rs module is documented, and that would be sad to have to go through the source file to get that information, imo :-)

@adamreichold
Copy link
Member Author

One last question: where would it reflect on the docs.rs pages? I don't see where the src/dtypes.rs module is documented, and that would be sad to have to go through the source file to get that information, imo :-)

This the documentation of the Element trait. I did consider putting on into the top-level section but the topics seems to niche IMHO. That trait is the center piece for matching NumPy data types and Rust types, so it seem the most appropriate yet still discoverable item to attach this to.

@jeertmans
Copy link

Ok I understand :)

looks good to me then!
Thanks for your help and work!

@adamreichold adamreichold merged commit 32740b3 into main Nov 11, 2023
35 checks passed
@adamreichold adamreichold deleted the linux-windows-data-models branch November 11, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent usize on Windows platforms
2 participants