changed core module call to _core

[euanwm]

Local tests pass
Mentioned on #453
Closes #454

[davidhewitt]

Thanks! It looks like this might be more complicated to keep numpy 1 support functional. There's failures related to #460, maybe once that merges we can rebase this and get some more information.

[kahojyun]

pybind11 checks numpy version before importing core module. https://github.com/pybind/pybind11/blob/master/include/pybind11/numpy.h#L175-L195

[euanwm]

Thanks! It looks like this might be more complicated to keep numpy 1 support functional. There's failures related to #460, maybe once that merges we can rebase this and get some more information.

@davidhewitt I rebased earlier - locally - with changes from #460 and hit an error on examples around a "libopenblas-dev" being missing. It did however pass through on check-msrv.

I'll wait until the #460 has been merged and the workflow has been run again to confirm that it isn't my ACT instance being weird.

[davidhewitt]

@euanwm in interest in shipping the release, I will push to this PR to apply the runtime check as per #458 (comment)

[euanwm]

@davidhewitt I did have a quick look at the root cause, and it's down to the change to _core in earlier numpy releases. Haven't had much time to dig into it further.

Do what you must with this PR, I suspect there's some deprecation required relating to older python support and would need to be a comp-time implementation.

[davidhewitt]

It seems like the runtime check worked, so I'll get on with merging this and shipping the release!