Add/edit/delete global flow variables in UI #76
Conversation
reddigari
requested review from
reelmatt,
cesaragv,
diegostruk and
matthew-t-smith
There was a problem hiding this comment.
Looks great! I think I found the source of the "missing nodes" bug mentioned in #75; requesting those changes here because I think it fits with the PR.
I did notice the persistent global flow variables a few times, but not in any reproducible way. The closest I got was a Load > Save > Clear loop that seemed similar to the bug back in #28, but again, I couldn't reliably reproduce it. I thought re-fetching the globals would've solved it, but I'd say the current behavior as "good enough".
| @@ -31,7 +33,9 @@ class Workspace extends React.Component { | |||
|
|
|||
| componentDidMount() { | |||
| this.getAvailableNodes(); | |||
There was a problem hiding this comment.
It looks like this is the bug I mentioned in #75 about order-of-operations. Since the Node list is now tied to a Workflow object, that call needs to come after API.initWorkflow(). Moving it into the then() block seems to do the trick.
Adds a menu as per Matt's wireframe where workflow-level variables are displayed and can be added, changed, and deleted.
Includes a change in the node config form component for numeric values to make sure they are passed as numbers in the JSON.
There seems to be a bug (not sure if it's here or on the back end) where the variables are not removed after refreshing the page (upon which the workflow SHOULD be reset). I'll keep looking into it.