-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds jest unit tests #77
Conversation
Looks great! I've never used snapshots to test against...how likely is it that they will need to be changed as we keep developing? I have a feeling they will be very useful vs manually writing assertions since we're strapped for time. |
@reddigari I used them before, and once the project is stable, they don't really need to change much. |
Reminder to add the execution of these tests to the Github Actions config once #75 is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're removing the package-lock.json
file do we also want to include that in .gitignore
so we don't recommit it going forward? I think its good practice to include the -lock
files in the repo, but I'm not entirely sure.
Oh I didn't catch that --- yeah it's good practice to leave them in because it ensures everyone's using the same versions and prevents dependency hell when people clone and install. @cesaragv could we put it back and see if we have the version issues you mentioned? |
@reddigari yes, I just did |
This PR sets up and adds the initial unit tests for the front-end.
As more files are touched during the run
npm test
, code coverage decreases