test: new GitHub Actions for front, back, Docker; increase PyWorkflow coverage to 83% #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Splits up steps, updates for new dir structure
reelmatt
requested review from
cesarnda,
diegostruk,
reddigari,
matthew-t-smith and
cesaragv
|
Any way to retain the Docker images as artifacts? I see there's a section for them but they aren't there. Also no way to view the log of the image builds? |
reddigari
approved these changes
May 9, 2020
|
Actions do support artifacts (and also caching which seems similar but different). I agree those would be good to implement, I just hadn't spent a lot of time on them. Re: logs, those should be available in the Action output. They should be in there from the first commit this PR, but I did separate out some steps at one point. If you expand "Build docker container" you should see something like: I think that's what you're talking about? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are now three GitHub Actions triggered on each push/PR:
test_backend.yml: Was the exiting GitHub Action. Builds/runs back-end server. Runs PyWorkflow unit tests and Postman API tests.test_frontend.yml: Builds the front-end server, runs the Jest tests.test_docker.yml: Builds and runs both Docker containers withdocker-compose.The front-end Action is currently failing. @cesaragv has #88 open to increase coverage and is working on the fix for the React hooks.
Also included in this PR is more PyWorkflow unit tests. Coverage had actually decreased to ~70% (mostly due to the addition of new Nodes); now back up to 83%.