Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.12 raises KeyError instead of TypeError #49

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Python 3.12 raises KeyError instead of TypeError #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
- JSON-RPC

+ Python 3.12 compatibility: Detection of a batched request used catching
for TypeError prior to Python 3.12. Since Python 3.12, KeyError is raised
on a bad slice index. This has been fixed to catch both exceptions.

0.8 (2016-10-31)
================

Expand Down
2 changes: 2 additions & 0 deletions pyramid_rpc/jsonrpc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,8 @@ def parse_request_POST(request):
batched = body[:]
except TypeError:
batched = None
except KeyError:
batched = None

if batched is not None:
request.batched_rpc_requests = batched
Expand Down