Fix CI #468
Merged
Fix CI #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pypy3.8 is prone to segfaults running pytest. This has been fixed in 3.9 and 3.10 (https://pypy.org/posts/2024/03/fixing-bug-incremental-gc.html) but 3.8 is no longer supported and has not been fixed.
mmerickel
approved these changes
Oct 10, 2024
miketheman
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several Github Actions builds were broken, so I made some changes to get green lights:
MacOS builds were failing because architecture was x64 but
macos-latestis now M1 machines (arm64). I decided to remove architecture from the matrix entirely. x86 is already disabled for Linux and MacOS, it only runs on Windows, so I don't know how useful it is.Alternative solutions: Use
macos-13, which is an x64 runner. Or expand the architecture matrix so we can run tests across Windows x86, Windows x64, Linux x64, and MacOS arm64.PyPy3.8 builds were failing because of a segfault during pytests. This issue has been resolved, but because pypy3.8 is no longer actively supported only pypy3.9 and 3.10 have been fixed. Because it's no longer supported, I think it's reasonable to remove entirely.