Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential get_wait hang if queue only receives a list in `put_w… #298

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

DanLCD
Copy link
Contributor

@DanLCD DanLCD commented Apr 16, 2024

Description

get_wait would never have its waiter woken up if a list were to be passed in an atomic put_wait with no subsequent calls of another type as an early return overlooked _wakeup_next.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
    • I have updated the changelog with a quick recap of my changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)
  • I have read and agree to the Developer Certificate of Origin for this contribution

…ait`

`get_wait` would never have its waiter woken up if a list were to be passed in an atomic `put_wait` with no subsequent calls of another type.
@EvieePy EvieePy merged commit d4ffab9 into PythonistaGuild:main Apr 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants