Fix bug where EDA augmentation recipe would not accept default Augmentation arguments #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jxmorris12
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Summary
This PR resolves a bug where using the EDA augmentation recipe would not work with the textattack augmentation cli. This issue was because the EDA recipe did not accept the default arguments defined in the Augmentation superclass. This change resolves this issue by accepting a var-keyword parameter, which is then passed to the component Augmenter objects used by the EDA recipe.
This PR resolved the bug raised in #796, which found that running the EDA recipe from the textattack augmentation cli would raise a
TypeError: __init__() got an unexpected keyword argument `high_yield`Changes