Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bumped compat entry for QEDbase #105

Closed
wants to merge 3 commits into from

Conversation

szabo137
Copy link
Member

@szabo137 szabo137 commented Oct 25, 2024

@szabo137
Copy link
Member Author

This is based on QEDjl-project/QEDcore.jl#78; consider merging this after the former is merged.

@szabo137
Copy link
Member Author

szabo137 commented Oct 25, 2024

docs build locally against https://github.com/szabo137/QEDcore.jl#bump-QEDbase-compat, therefore, consider merging, if QEDjl-project/QEDcore.jl#78 is merged and QEDcore is released.

Project.toml Outdated Show resolved Hide resolved
docs/Project.toml Outdated Show resolved Hide resolved
@SimeonEhrig
Copy link
Member

@szabo137 please rebase

@AntonReinhard
Copy link
Member

I think with #106 this can now be closed

@SimeonEhrig
Copy link
Member

The PR also introduce a compat section in the docs/Project.toml. Is this something which we want to do?

@AntonReinhard
Copy link
Member

The PR also introduce a compat section in the docs/Project.toml. Is this something which we want to do?

Good question, I don't know if it's necessary?

@szabo137
Copy link
Member Author

I tried to solve the compat problem for docs building by introducing the compat section in docs/Project.toml. However, I guess this is no longer necessary with the fixed from you.

Therefore, I close this.

@szabo137 szabo137 closed this Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants