Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add code formatter job #13

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Conversation

SimeonEhrig
Copy link
Member

No description provided.

@szabo137
Copy link
Member

Could you please commit the formatted version of the branch to see that the formatter job passes and the code is mergeable again?

@SimeonEhrig
Copy link
Member Author

@szabo137 Hit the button :-)

- format manually the source code
Copy link
Member

@szabo137 szabo137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no concerns with this one! Approving and merging.

Just a small comment on the practice: I think it would be nice to perform the formatting in a separate commit. Then it is easier to see the actual changes done in this PR.

@szabo137 szabo137 merged commit 3c5ccc3 into QEDjl-project:dev Sep 26, 2023
1 check passed
@szabo137 szabo137 added this to the Release 0.1.0 milestone Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants