-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal for PhaseSpacePoint improvement #63
Conversation
…ests, rearranged files
I just noticed I'm still missing the new implementation of |
Co-authored-by: Anton Reinhard <[email protected]>
@AntonReinhard Seems like something broke with this one. Maybe it is better to wait with this one until #59 is merged. After that, a rebase of this one seems easy. |
f11eef0
to
b3a8536
Compare
db547ef
to
3b479ab
Compare
Should be building fine for now @szabo137 I'm not sure if it might actually be a good idea to merge this before #59 instead of the other way around, since there are slight changes in how the PSP behaves. For example, I added a Also, I noticed that there is no public interface for a process' spins/polarizations, which means it's now impossible to get a particle's spin. |
…into 58-ps-improve
I have tentatively merged #59 into this, but keeping it local for now. I'm playing around with it now and am noticing that the broadcast in |
ebd1339
to
6da8127
Compare
@szabo137 Should be ready to merge now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work! Only some minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Proposal for a rework of the PhaseSpacePoint, according to Issue #58
I did a lot of type magic with recursive variadic templates to find out type information and get functions perfectly type stable. Constructing phase space points is now always type stable and takes a maximum of ~11ns for me when constructing from momenta.
Some of the tests are failing for now because some of the interfaces currently don't expect tuples from the PSP implementation. It might make sense to fix this in #59