Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove interfaces and functionality that move #74

Merged
merged 6 commits into from
Jun 28, 2024
Merged

Remove interfaces and functionality that move #74

merged 6 commits into from
Jun 28, 2024

Conversation

AntonReinhard
Copy link
Member

@AntonReinhard AntonReinhard commented Jun 6, 2024 •
edited
Loading

The interfaces and functionality have moved to QEDbase and QEDcore.

@szabo137
Copy link
Member

szabo137 commented Jun 25, 2024 •
edited
Loading

@AntonReinhard Please update QEDbase and push again. What's needed to fix this?

Edit: Seems like QEDbase-compat is broken. Maybe rebasing would be good :)

@AntonReinhard AntonReinhard marked this pull request as ready for review June 25, 2024 19:55
@AntonReinhard
Copy link
Member Author

@AntonReinhard Please update QEDbase and push again. What's needed to fix this?

Edit: Seems like QEDbase-compat is broken. Maybe rebasing would be good :)

This needs to be merged: QEDjl-project/QEDcore.jl#25 and QEDcore needs to be released. The implementations of PhaseSpacePoint for example move there but aren't yet available.

@AntonReinhard
Copy link
Member Author

Also, the QEDbase. replacements in QEDcore need to be removed again I think.

@AntonReinhard AntonReinhard marked this pull request as draft June 25, 2024 20:36
@AntonReinhard
Copy link
Member Author

This builds and tests locally with the changes from QEDjl-project/QEDcore.jl#29 and the dev-branch of QEDbase.

@AntonReinhard AntonReinhard mentioned this pull request Jun 27, 2024
Merged
@AntonReinhard
Copy link
Member Author

The doc building fails because for some reason it refuses to get QEDbase 0.2 instead of 0.1. I have no idea why.

@AntonReinhard AntonReinhard marked this pull request as ready for review June 27, 2024 13:02
@AntonReinhard
Copy link
Member Author

The doc building fails because for some reason it refuses to get QEDbase 0.2 instead of 0.1. I have no idea why.

I found the problem. Should be ready for review now. @szabo137 ping

szabo137
szabo137 approved these changes Jun 28, 2024
View reviewed changes
Copy link
Member

@szabo137 szabo137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGFM. In a separate PR, we should remove the implementations of differential_probability, total_probability and differential_cross_section, total_cross_section, because we add them to QEDbase: QEDjl-project/QEDbase.jl#87

@szabo137 szabo137 merged commit 1b35375 into QEDjl-project:dev Jun 28, 2024
4 checks passed
@AntonReinhard AntonReinhard deleted the remove_interfaces branch June 28, 2024 08:33
@szabo137 szabo137 added this to the Release-next milestone Jul 15, 2024
@szabo137 szabo137 added 09 - Maintenance Related to maintenance, housekeeping, repo-config moved-to-QEDcore labels Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szabo137 szabo137 szabo137 approved these changes

Assignees
No one assigned
Labels
09 - Maintenance Related to maintenance, housekeeping, repo-config moved-to-QEDcore
Projects
None yet
Milestone
Release 0.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@AntonReinhard @szabo137