Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove abstract cs and probability implementations #87

Merged
merged 3 commits into from
Jun 28, 2024

Conversation

AntonReinhard
Copy link
Member

The implementations of the cross sections and probability functions for abstract processes have moved to QEDbase, see QEDjl-project/QEDbase.jl#87. They are therefore now deleted here.

Fixes issue QEDjl-project/QEDbase.jl#86

szabo137
szabo137 previously approved these changes Jun 28, 2024
Copy link
Member

@szabo137 szabo137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fast PR! Looks good for me. Will merge if the pipeline succeeds.

Edit: Oh, the tests, you are right 😅

@AntonReinhard
Copy link
Member Author

AntonReinhard commented Jun 28, 2024

Thanks for the fast PR! Looks good for me. Will merge if the pipeline succeeds.

Edit: Oh, the tests, you are right 😅

Yes, almost forgot 😅 Should be good if the pipeline goes through 👍
Feel free to merge then.

Edit: Right, it won't succeed. It now needs the implementations from QEDbase. I think we need to target this branch in the QEDbase integration tests, then merge the QEDbase PR, then merge this one.

@szabo137
Copy link
Member

Thanks for the fast PR! Looks good for me. Will merge if the pipeline succeeds.
Edit: Oh, the tests, you are right 😅

Yes, almost forgot 😅 Should be good if the pipeline goes through 👍 Feel free to merge then.

Edit: Right, it won't succeed. It now needs the implementations from QEDbase. I think we need to target this branch in the QEDbase integration tests, then merge the QEDbase PR, then merge this one.

Could you please add

CI_UNIT_PKG_URL_QEDbase: https://github.com/szabo137/QEDbase.jl#2492e986972de30fadd68cd7fa7946dc4d888a61

to your last commit message? Then the unit tests should succeed. If so, we can tell QEDjl-project/QEDbase.jl#87 to use this fix here and merge it. Afterwards we can merge here.

@AntonReinhard
Copy link
Member Author

Something seems to break with the pipeline. It finds and clones the correct QEDbase version, but somehow there seems to be a git merge happening in the Project.toml, leading to a parsing error

@szabo137
Copy link
Member

Something seems to break with the pipeline. It finds and clones the correct QEDbase version, but somehow there seems to be a git merge happening in the Project.toml, leading to a parsing error

My bad, wrong commit hash 🤦‍♂️
This is the correct one: fb4c800acc99ffe83efe558a5a094e63eed9abde

@szabo137
Copy link
Member

Please remove the CI_UNIT_PKG_URL_QEDbase from the last commit message and force push again.. this should use the current QEDbase#dev and therefore should pass the tests.

@szabo137 szabo137 merged commit a5bdae5 into QEDjl-project:dev Jun 28, 2024
2 checks passed
@szabo137 szabo137 added this to the Release-next milestone Jul 15, 2024
@szabo137 szabo137 added 09 - Maintenance Related to maintenance, housekeeping, repo-config moved-to-QEDcore labels Jul 15, 2024
@AntonReinhard AntonReinhard deleted the remove_functions branch September 2, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
09 - Maintenance Related to maintenance, housekeeping, repo-config moved-to-QEDcore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants